Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force no become on localhost (fixes: #178) #185

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

ticoombs
Copy link
Collaborator

@ticoombs ticoombs commented Oct 9, 2023

Issue

When using --become this tells ansible to always get root (or whatever become_user is). This includes when we delegate
Initial #178 was insufficient

Solution

when we delegate make sure we become: false

Reference

#ansible-chat in matrix room (https://matrix.to/#/!XunuLxRTzInMzxQxdS:discuss.online/$f9EsmBIH1UL9O9kmuUhhprsjfhPH73xd7ac1PU_JlYc?via=discuss.online&via=matrix.org&via=nope.chat)

improvement on #178

@ticoombs ticoombs added this to the 1.2.1 milestone Oct 9, 2023
@ticoombs ticoombs self-assigned this Oct 9, 2023
@ticoombs ticoombs changed the title fix: force no become on localhost fix: force no become on localhost (improvement on #178) Oct 9, 2023
@ticoombs ticoombs changed the title fix: force no become on localhost (improvement on #178) fix: force no become on localhost (fixes: #178) Oct 9, 2023
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint is failing but its unrelated to this one. I'll merge and we'll have to handle the other one later.

@dessalines dessalines merged commit 31f1137 into main Oct 9, 2023
0 of 2 checks passed
@dessalines
Copy link
Member

Ansible lint is passing for me locally, probably a version issue having to do with the alpine ansible-lint package being older:

arch: 6.20.4.dev0

alpine: 6.20.3-r0

@ticoombs ticoombs deleted the ticoombs-patch-3 branch October 9, 2023 23:00
usr3 pushed a commit to usr3/futurology-lemmy that referenced this pull request Dec 23, 2023
snowe2010 pushed a commit to programming-dot-dev/lemmy-ansible that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants