Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mark multiple posts as read, and other API changes. #201

Merged
merged 10 commits into from
Oct 20, 2023
Merged

Adding mark multiple posts as read, and other API changes. #201

merged 10 commits into from
Oct 20, 2023

Conversation

dessalines
Copy link
Member

No description provided.

SleeplessOne1917
SleeplessOne1917 reviewed Oct 17, 2023
View reviewed changes
src/types/CommentAggregates.ts
@@ -9,6 +9,4 @@ export interface CommentAggregates {
downvotes: /* integer */ number;
published: string;
child_count: number;
hot_rank: number;
controversy_rank: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there supposed to be a controversial sort type to go along with this controversy rank?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, its in SortType and CommentSortType.

@SleeplessOne1917
Copy link
Member

  1. Should there be new types for importing/exporting settings?
  2. Add methods for user settings import/export
  3. Should we get the animated images setting in this PR as well?

@dessalines
Copy link
Member Author

1 & 2

Good call, I'll add those.

3

That looks merged now, so I'll update it.

@dessalines dessalines marked this pull request as draft October 17, 2023 16:19
@dessalines
Copy link
Member Author

@Nutomic Since the UserSettingsBackup struct is not in the api_common crate like the other API responses / requests, and it doesn't use ts-rs, its not properly creating the type, so front ends can't use it.

I tried for a bit to fix it, but unfortunately the structs use ObjectId<ApubCommunity... which isn't accessible from api_common (and those should be vectors of DbUrl s anyway).

@dessalines
Copy link
Member Author

The user export import we should wait on, but I'll make an issue for it.

@dessalines dessalines marked this pull request as ready for review October 17, 2023 18:10
@dessalines dessalines marked this pull request as draft October 19, 2023 16:52
@dessalines dessalines marked this pull request as ready for review October 20, 2023 00:20
@dessalines dessalines enabled auto-merge (squash) October 20, 2023 00:21
@dessalines
Copy link
Member Author

Merging so I can get a lemmy-ui RC out.

@dessalines dessalines merged commit 24eed9e into main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessOne1917 SleeplessOne1917 Awaiting requested review from SleeplessOne1917 SleeplessOne1917 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dessalines @SleeplessOne1917