-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The audio of an embedded video can be made to auto-play outside of the post #650
Comments
I think the best solution for this problem might be to add a check so that iframe tags are not allowed in user submitted text. |
I'd rather just turn off allowing html in the markdown parser. It was always a potential security problem. |
Some html is harmless (like tables). Maybe it could use a whitelist for safe html tags? If not, disabling html completely is probably best. |
Markdown-it really suggests you just turn it off. https://github.com/markdown-it/markdown-it/blob/master/docs/security.md We've seen a few exploits using it so far, and html also isn't likely going to work on any other clients anyway. |
where you deployed your website? |
Hey Can You please tell me where you are hosting your website and what is its cost? |
How can one add/upload video in the post like picture now that html is disabled? |
@Xeunyx-Cypher Post a link to youtube, peertube etc. Embeds for those will be supported in 0.17. |
@Nutomic |
Found a bug? Please fill out the sections below. 👍
Issue Summary
A summary of the bug.
If you are on a page which contains the link to a post, and that post contains a video embedded using iframe, the audio of the video will be heard (if you access via a URL externally, then the auto play will occur as soon as an action is taken on that page, for example, changing from "All" to "Local", or from "New" to "Hot".) This autoplay occurs even if the browser is set to block autoplay.
Steps to Reproduce
Create a post and embed a video beginning with a block such as the following:
Then, go to the sub-lemmy that contains that post. If the audio does not autoplay, change the "Sort type".
You can access an example by going to:
https://mander.xyz/c/test
Then change the "Sort type" to something else.
EDIT: I have noticed the following. If the post has a first sentence, then a space, and after this the embedding block, then the autoplay will not happen. For example:
Won't autoplay. Maybe this provides another clue about what is going on.
Technical details
I have tested this in Firefox both for arch linux and an android phone.
The text was updated successfully, but these errors were encountered: