Reorganize federation tests (#2092)

* Reorganize apub protocol tests

* Reorder apub protocol struct members to clarify mandatory/optional fields

crates/apub/assets/lemmy/objects/instance.json

@@ -1,23 +1,4 @@
 {
-  "@context": [
-    "https://www.w3.org/ns/activitystreams",
-    {
-      "stickied": "as:stickied",
-      "pt": "https://join-lemmy.org#",
-      "sc": "http://schema.org#",
-      "matrixUserId": {
-        "type": "sc:Text",
-        "id": "as:alsoKnownAs"
-      },
-      "sensitive": "as:sensitive",
-      "comments_enabled": {
-        "type": "sc:Boolean",
-        "id": "pt:commentsEnabled"
-      },
-      "moderators": "as:moderators"
-    },
-    "https://w3id.org/security/v1"
-  ],
   "type": "Service",
   "id": "https://enterprise.lemmy.ml/",
   "name": "Enterprise",

crates/apub/assets/lemmy/objects/person.json

@@ -16,7 +16,7 @@
     "type": "Image",
     "url": "https://enterprise.lemmy.ml/pictrs/image/XenaYI5hTn.png"
   },
-  "matrix_user_id": "@picard:matrix.org",
+  "matrixUserId": "@picard:matrix.org",
   "inbox": "https://enterprise.lemmy.ml/u/picard/inbox",
   "outbox": "https://enterprise.lemmy.ml/u/picard/outbox",
   "endpoints": {

crates/apub/assets/mastodon/activities/create_note.json

@@ -1,4 +1,11 @@
 {
+  "@context": [
+    "https://www.w3.org/ns/activitystreams",
+    {
+      "ostatus": "http://ostatus.org#",
+      "atomUri": "ostatus:atomUri"
+    }
+  ],
   "id": "https://mastodon.madrid/users/felix/statuses/107224289116410645/activity",
   "type": "Create",
   "actor": "https://mastodon.madrid/users/felix",

crates/apub/assets/mastodon/activities/follow.json

@@ -0,0 +1,7 @@
+{
+  "@context": "https://www.w3.org/ns/activitystreams",
+  "id": "https://masto.asonix.dog/1ea87517-63c5-4118-8831-460ee641b2cf",
+  "type": "Follow",
+  "actor": "https://masto.asonix.dog/users/asonix",
+  "object": "https://ds9.lemmy.ml/c/testcom"
+}

crates/apub/assets/mastodon/activities/undo_follow.json

@@ -0,0 +1,13 @@
+{
+  "@context": "https://www.w3.org/ns/activitystreams",
+  "id": "https://masto.asonix.dog/users/asonix#follows/449/undo",
+  "type": "Undo",
+  "actor": "https://masto.asonix.dog/users/asonix",
+  "object": {
+    "id": "https://masto.asonix.dog/1ea87517-63c5-4118-8831-460ee641b2cf",
+    "type": "Follow",
+    "actor": "https://masto.asonix.dog/users/asonix",
+    "object": "https://ds9.lemmy.ml/c/testcom"
+  }
+}
+

crates/apub/assets/smithereen/objects/note.json

@@ -28,5 +28,11 @@
     }
   },
   "sensitive": false,
-  "likes": "https://friends.grishka.me/posts/66561/likes"
+  "likes": "https://friends.grishka.me/posts/66561/likes",
+  "@context": [
+    "https://www.w3.org/ns/activitystreams",
+    {
+      "sensitive": "as:sensitive"
+    }
+  ]
 }

crates/apub/src/collections/community_moderators.rs

@@ -138,10 +138,13 @@ impl ApubObject for ApubCommunityModerators {
 #[cfg(test)]
 mod tests {
   use super::*;
-  use crate::objects::{
-    community::tests::parse_lemmy_community,
-    person::tests::parse_lemmy_person,
-    tests::{file_to_json_object, init_context},
+  use crate::{
+    objects::{
+      community::tests::parse_lemmy_community,
+      person::tests::parse_lemmy_person,
+      tests::init_context,
+    },
+    protocol::tests::file_to_json_object,
   };
   use lemmy_apub_lib::activity_queue::create_activity_queue;
   use lemmy_db_schema::{

crates/apub/src/objects/comment.rs

@@ -125,7 +125,6 @@ impl ApubObject for ApubComment {
       published: Some(convert_datetime(self.published)),
       updated: self.updated.map(convert_datetime),
       tag: maa.tags,
-      unparsed: Default::default(),
     };
 
     Ok(note)
@@ -208,12 +207,15 @@ impl ApubObject for ApubComment {
 #[cfg(test)]
 pub(crate) mod tests {
   use super::*;
-  use crate::objects::{
-    community::{tests::parse_lemmy_community, ApubCommunity},
-    instance::ApubSite,
-    person::{tests::parse_lemmy_person, ApubPerson},
-    post::ApubPost,
-    tests::{file_to_json_object, init_context},
+  use crate::{
+    objects::{
+      community::{tests::parse_lemmy_community, ApubCommunity},
+      instance::ApubSite,
+      person::{tests::parse_lemmy_person, ApubPerson},
+      post::ApubPost,
+      tests::init_context,
+    },
+    protocol::tests::file_to_json_object,
   };
   use assert_json_diff::assert_json_include;
   use lemmy_apub_lib::activity_queue::create_activity_queue;

crates/apub/src/objects/community.rs

@@ -102,7 +102,6 @@ impl ApubObject for ApubCommunity {
       public_key: self.get_public_key()?,
       published: Some(convert_datetime(self.published)),
       updated: self.updated.map(convert_datetime),
-      unparsed: Default::default(),
     };
     Ok(group)
   }
@@ -214,9 +213,9 @@ impl ApubCommunity {
 #[cfg(test)]
 pub(crate) mod tests {
   use super::*;
-  use crate::objects::{
-    instance::tests::parse_lemmy_instance,
-    tests::{file_to_json_object, init_context},
+  use crate::{
+    objects::{instance::tests::parse_lemmy_instance, tests::init_context},
+    protocol::tests::file_to_json_object,
   };
   use lemmy_apub_lib::activity_queue::create_activity_queue;
   use lemmy_db_schema::{source::site::Site, traits::Crud};

crates/apub/src/objects/instance.rs

@@ -1,7 +1,7 @@
 use crate::{
   check_is_apub_id_valid,
   objects::get_summary_from_string_or_source,
-  protocol::{objects::instance::Instance, ImageObject, Source, Unparsed},
+  protocol::{objects::instance::Instance, ImageObject, Source},
 };
 use activitystreams_kinds::actor::ServiceType;
 use chrono::NaiveDateTime;
@@ -86,7 +86,6 @@ impl ApubObject for ApubSite {
       public_key: self.get_public_key()?,
       published: convert_datetime(self.published),
       updated: self.updated.map(convert_datetime),
-      unparsed: Unparsed::default(),
     };
     Ok(instance)
   }
@@ -186,7 +185,7 @@ pub(in crate::objects) async fn fetch_instance_actor_for_object(
 #[cfg(test)]
 pub(crate) mod tests {
   use super::*;
-  use crate::objects::tests::{file_to_json_object, init_context};
+  use crate::{objects::tests::init_context, protocol::tests::file_to_json_object};
   use lemmy_apub_lib::activity_queue::create_activity_queue;
   use lemmy_db_schema::traits::Crud;
   use serial_test::serial;

crates/apub/src/objects/mod.rs

@@ -41,8 +41,7 @@ pub(crate) mod tests {
   use lemmy_websocket::{chat_server::ChatServer, LemmyContext};
   use reqwest::Client;
   use reqwest_middleware::ClientBuilder;
-  use serde::de::DeserializeOwned;
-  use std::{fs::File, io::BufReader, sync::Arc};
+  use std::sync::Arc;
   use tokio::sync::Mutex;
 
   // TODO: would be nice if we didnt have to use a full context for tests.
@@ -90,10 +89,4 @@ pub(crate) mod tests {
     .start();
     LemmyContext::create(pool, chat_server, client, activity_queue, settings, secret)
   }
-
-  pub(crate) fn file_to_json_object<T: DeserializeOwned>(path: &str) -> Result<T, LemmyError> {
-    let file = File::open(path)?;
-    let reader = BufReader::new(file);
-    Ok(serde_json::from_reader(reader)?)
-  }
 }

crates/apub/src/objects/person.rs

@@ -105,7 +105,6 @@ impl ApubObject for ApubPerson {
       }),
       public_key: self.get_public_key()?,
       updated: self.updated.map(convert_datetime),
-      unparsed: Default::default(),
       inbox: self.inbox_url.clone().into(),
     };
     Ok(person)
@@ -204,9 +203,9 @@ pub(crate) mod tests {
   use crate::{
     objects::{
       instance::{tests::parse_lemmy_instance, ApubSite},
-      tests::{file_to_json_object, init_context},
+      tests::init_context,
     },
-    protocol::objects::instance::Instance,
+    protocol::{objects::instance::Instance, tests::file_to_json_object},
   };
   use lemmy_apub_lib::activity_queue::create_activity_queue;
   use lemmy_db_schema::{source::site::Site, traits::Crud};

crates/apub/src/objects/post.rs

@@ -122,7 +122,6 @@ impl ApubObject for ApubPost {
       stickied: Some(self.stickied),
       published: Some(convert_datetime(self.published)),
       updated: self.updated.map(convert_datetime),
-      unparsed: Default::default(),
     };
     Ok(page)
   }
@@ -207,11 +206,14 @@ impl ApubObject for ApubPost {
 #[cfg(test)]
 mod tests {
   use super::*;
-  use crate::objects::{
-    community::tests::parse_lemmy_community,
-    person::tests::parse_lemmy_person,
-    post::ApubPost,
-    tests::{file_to_json_object, init_context},
+  use crate::{
+    objects::{
+      community::tests::parse_lemmy_community,
+      person::tests::parse_lemmy_person,
+      post::ApubPost,
+      tests::init_context,
+    },
+    protocol::tests::file_to_json_object,
   };
   use lemmy_apub_lib::activity_queue::create_activity_queue;
   use lemmy_db_schema::source::site::Site;

crates/apub/src/objects/private_message.rs

@@ -90,7 +90,6 @@ impl ApubObject for ApubPrivateMessage {
       source: Some(Source::new(self.content.clone())),
       published: Some(convert_datetime(self.published)),
       updated: self.updated.map(convert_datetime),
-      unparsed: Default::default(),
     };
     Ok(note)
   }
@@ -159,9 +158,9 @@ impl ApubObject for ApubPrivateMessage {
 #[cfg(test)]
 mod tests {
   use super::*;
-  use crate::objects::{
-    person::ApubPerson,
-    tests::{file_to_json_object, init_context},
+  use crate::{
+    objects::{person::ApubPerson, tests::init_context},
+    protocol::tests::file_to_json_object,
   };
   use assert_json_diff::assert_json_include;
   use lemmy_apub_lib::activity_queue::create_activity_queue;

crates/apub/src/protocol/activities/block/block_user.rs

@@ -17,13 +17,14 @@ pub struct BlockUser {
   pub(crate) target: ObjectId<SiteOrCommunity>,
   #[serde(rename = "type")]
   pub(crate) kind: BlockType,
+  pub(crate) id: Url,
+
   /// Quick and dirty solution.
   /// TODO: send a separate Delete activity instead
   pub(crate) remove_data: Option<bool>,
   /// block reason, written to mod log
   pub(crate) summary: Option<String>,
-  pub(crate) id: Url,
+  pub(crate) expires: Option<DateTime<FixedOffset>>,
   #[serde(flatten)]
   pub(crate) unparsed: Unparsed,
-  pub(crate) expires: Option<DateTime<FixedOffset>>,
 }

crates/apub/src/protocol/activities/block/mod.rs

@@ -8,8 +8,8 @@ mod tests {
     tests::test_parse_lemmy_item,
   };
 
-  #[actix_rt::test]
-  async fn test_parse_lemmy_block() {
+  #[test]
+  fn test_parse_lemmy_block() {
     test_parse_lemmy_item::<BlockUser>("assets/lemmy/activities/block/block_user.json").unwrap();
     test_parse_lemmy_item::<UndoBlockUser>("assets/lemmy/activities/block/undo_block_user.json")
       .unwrap();

crates/apub/src/protocol/activities/block/undo_block_user.rs

@@ -19,6 +19,7 @@ pub struct UndoBlockUser {
   #[serde(rename = "type")]
   pub(crate) kind: UndoType,
   pub(crate) id: Url,
+
   #[serde(flatten)]
   pub(crate) unparsed: Unparsed,
 }

crates/apub/src/protocol/activities/community/add_mod.rs

@@ -17,6 +17,7 @@ pub struct AddMod {
   #[serde(rename = "type")]
   pub(crate) kind: AddType,
   pub(crate) id: Url,
+
   #[serde(flatten)]
   pub(crate) unparsed: Unparsed,
 }

crates/apub/src/protocol/activities/community/announce.rs

@@ -20,6 +20,7 @@ pub struct AnnounceActivity {
   #[serde(rename = "type")]
   pub(crate) kind: AnnounceType,
   pub(crate) id: Url,
+
   #[serde(flatten)]
   pub(crate) unparsed: Unparsed,
 }

crates/apub/src/protocol/activities/community/mod.rs

@@ -17,8 +17,8 @@ mod tests {
     tests::test_parse_lemmy_item,
   };
 
-  #[actix_rt::test]
-  async fn test_parse_lemmy_community() {
+  #[test]
+  fn test_parse_lemmy_community_activities() {
     test_parse_lemmy_item::<AnnounceActivity>(
       "assets/lemmy/activities/community/announce_create_page.json",
     )

crates/apub/src/protocol/activities/community/remove_mod.rs

@@ -17,6 +17,7 @@ pub struct RemoveMod {
   pub(crate) kind: RemoveType,
   pub(crate) target: Url,
   pub(crate) id: Url,
+
   #[serde(flatten)]
   pub(crate) unparsed: Unparsed,
 }

crates/apub/src/protocol/activities/community/report.rs

@@ -19,6 +19,7 @@ pub struct Report {
   #[serde(rename = "type")]
   pub(crate) kind: FlagType,
   pub(crate) id: Url,
+
   #[serde(flatten)]
   pub(crate) unparsed: Unparsed,
 }

crates/apub/src/protocol/activities/community/update.rs

@@ -22,6 +22,7 @@ pub struct UpdateCommunity {
   #[serde(rename = "type")]
   pub(crate) kind: UpdateType,
   pub(crate) id: Url,
+
   #[serde(flatten)]
   pub(crate) unparsed: Unparsed,
 }

crates/apub/src/protocol/activities/create_or_update/comment.rs

@@ -21,6 +21,7 @@ pub struct CreateOrUpdateComment {
   #[serde(rename = "type")]
   pub(crate) kind: CreateOrUpdateType,
   pub(crate) id: Url,
+
   #[serde(flatten)]
   pub(crate) unparsed: Unparsed,
 }