Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointing a mod is reflected twice in the modlog / Add TransferMod modlog entry #1437

Closed
shilangyu opened this issue Feb 18, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@shilangyu
Copy link
Contributor

shilangyu commented Feb 18, 2021

Issue Summary

When visiting https://lemmy.ml/modlog one can see that most Appointed as a mod to the community entries are duplicated:

image

Weirdly enough this isn't always the case:

image

(the appointment of a new Elm mod appears only once)

This might perhaps be just that the action was indeed performed twice each time, I'm not sure how to debug that.

Technical details

I know this isn't a lemmy-ui issue because I am experiencing the same thing when consuming the API directly in lemmur


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@shilangyu shilangyu added the bug Something isn't working label Feb 18, 2021
@dessalines
Copy link
Member

dessalines commented Feb 18, 2021

So what's going on is that these aren't just appoints. I'm appointing them as a mod, then I'm transferring the community ownership to them. For both these I'm just using the ModAddCommunity type for the modlog... Not sure if an additionall ModTransferCommunity type is necessary.

@shilangyu
Copy link
Contributor Author

Ah gotcha, not a bug then

Not sure if an additional ModTransferCommunity type is necessary.

Probably makes sense for completeness but doesn't seem too necessary

@dessalines dessalines changed the title Appointing a mod is reflected twice in the modlog Appointing a mod is reflected twice in the modlog / Add TransferMod modlog entry Aug 16, 2021
Nutomic added a commit that referenced this issue Aug 18, 2021
Adding ModTransferCommunity to modlog in API. Fixes #1437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants