Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to make sure Instances are live #2221

Closed
Kap2022 opened this issue Apr 16, 2022 · 4 comments
Closed

Check to make sure Instances are live #2221

Kap2022 opened this issue Apr 16, 2022 · 4 comments
Labels
enhancement New feature or request extra: good first issue Good for newcomers

Comments

@Kap2022
Copy link

Kap2022 commented Apr 16, 2022

Issue Summary

Re: https://lemmy.ml/instances

When you are looking through this list of instances, you find a lot of them are not active. This takes away from the user experience and could give a bad first impression to people.

My suggestion would be to run an automated check once a day or once a week and exclude them from the list if they are not active.

Examples of dead links included in the instances list:
https://eope.xyz/
https://forum.purplerabbit.xyz/
https://lemmy.161.social/
https://lemmy.2labz.com/
etc

@Kap2022 Kap2022 added the bug Something isn't working label Apr 16, 2022
@dessalines
Copy link
Member

Seems like a good idea, especially in order to not keep sending dead instances activities.

It is complicated tho by the fact that an instance might go down for a while, then come back up. @Nutomic might have some ideas. I'd rather it not have to be explicitly defined ( IE add the dead instances to the blocklist ), but that might be unavoidable.

@Nutomic
Copy link
Member

Nutomic commented Apr 22, 2022

If its only about the /instances page, it should be easy enough to list only instances from which we received a new post in the last 30 days.

@dessalines
Copy link
Member

It might go beyond that... that lemmy will try to push activities to instances that have been dead, potentially for more than a year.

@Nutomic
Copy link
Member

Nutomic commented Apr 26, 2022

Yes thats a separate issue.

@Nutomic Nutomic added enhancement New feature or request extra: good first issue Good for newcomers and removed bug Something isn't working labels Jan 15, 2023
Nutomic added a commit to cetra3/lemmy that referenced this issue Jul 19, 2023
* Check for dead federated instances (fixes LemmyNet#2221)

* move to apub crate, use timestamp

* make it compile

* clippy

* use moka to cache blocklists, dead instances, restore orig scheduled tasks

* remove leftover last_alive var

* error handling

* wip

* fix alive check for instances without nodeinfo, add coalesce

* clippy

* move federation blocklist cache to LemmyNet#3486

* unused deps
Nutomic added a commit that referenced this issue Jul 21, 2023
* Check for dead federated instances (fixes #2221)

* move to apub crate, use timestamp

* make it compile

* clippy

* use moka to cache blocklists, dead instances, restore orig scheduled tasks

* remove leftover last_alive var

* error handling

* wip

* fix alive check for instances without nodeinfo, add coalesce

* clippy

* move federation blocklist cache to #3486

* unused deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extra: good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants