Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federated actions are not aware of remote blocklist #2291

Closed
Kap2022 opened this issue May 30, 2022 · 6 comments
Closed

Federated actions are not aware of remote blocklist #2291

Kap2022 opened this issue May 30, 2022 · 6 comments
Labels
area: federation support federation via activitypub bug Something isn't working

Comments

@Kap2022
Copy link

Kap2022 commented May 30, 2022

I added a comment to this issue that was closed prior to 16.4 LemmyNet/lemmy-ui#633
Having upgraded it is better, but still not right.

Today I want to report a different problem with the search feature within the community drop down box.

Lemmy.ml has blocked exploding-heads.com
exploding-heads.com has not blocked lemmy.ml

This means exploding-heads users can subscribe to communities on lemmy.ml but not contribute to them (post or comment)

So here is the problem, when creating a post on exploding-heads.com and selecting the community from the community search/drop down box - the communities you are presented with to choose from include communities on Lemmy.ml to which you are not allowed to post or comment. I do not think they should be presented to you i for whatever reason you are not allowed to contribute - either the instance of which you are a member is blocked or you personally are blocked.

If you do select the lemmy.ml instance, then you are not given any error message either - the post just goes nowhere without you knowing.

I believe, but do not know for a fact, the same applies to personal messages e.g. I would be allowed to select a user of lemmy.ml to send a message to - but unbeknownst to me they would never get it if the instance I am a member of is blocked by the instance the proposed recipient is a member of. I do not think Lemmy should be in the business of blocking one on one personal communications. Leave it to the recipient to decide and ban the send if appropriate.

@Kap2022 Kap2022 added the bug Something isn't working label May 30, 2022
@dessalines
Copy link
Member

@Nutomic all these federation actions are async correct? It might be necessary to move a federation check to the API, in order to return a "Instance has been blocked" error.

@Nutomic Nutomic transferred this issue from LemmyNet/lemmy-ui Jun 2, 2022
@Nutomic Nutomic added the area: federation support federation via activitypub label Jun 2, 2022
@Nutomic
Copy link
Member

Nutomic commented Jun 2, 2022

Yes this one is tricky. Federated actions are sent in a background thread, and its possible that they fail and get retried after some hours. So there is no real possibility to wait for an error from the remote instance. One solution would be to federate the allowlist/blocklist between instances, so the sending instance can check if federation is permitted.

The way that instance blocks work is that they block all communication with that instance. So making an exception for private messages is not really feasible.

@Nutomic Nutomic changed the title Community drop box down issues Federated actions are not aware of remote blocklist Jun 2, 2022
@dessalines
Copy link
Member

dessalines commented Jun 2, 2022

Could we tag in someone from another apub project to ask how they handle this? Maybe @asonix has some ideas.

@asonix
Copy link
Collaborator

asonix commented Jun 3, 2022

I'm not sure about a good solution to this either. One option would be sending a Block activity to the blocked instance after an instance block so they know not to present blocked content, but I haven't thought too much about this specific scenario

@Nutomic
Copy link
Member

Nutomic commented Jun 7, 2022

@Kap2022 As a workaround, it should help to block lemmy.ml from your side as well.

@dessalines
Copy link
Member

Stale issue, and I don't think there's any way around this short of fetching every remote blocklist.

@dessalines dessalines closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: federation support federation via activitypub bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants