Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API tests for image endpoints #4105

Closed
4 tasks done
Nutomic opened this issue Oct 25, 2023 · 0 comments
Closed
4 tasks done

Create API tests for image endpoints #4105

Nutomic opened this issue Oct 25, 2023 · 0 comments
Labels
area: maintenance enhancement New feature or request

Comments

@Nutomic
Copy link
Member

Nutomic commented Oct 25, 2023

Requirements

  • Is this a feature request? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a feature request? Do not put multiple feature requests in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Is your proposal related to a problem?

At the moment we dont have any API tests for image uploads and related functionality. This would be very helpful to ensure that functionality such as image proxying (#4035) is working correctly.

Describe the solution you'd like.

Make pictrs available for API tests and write test cases for basic functionality like uploading and downloading an image. There are various ways to run pictrs, including binary downloads from the project repo. That is probably the easiest option, but it still requires some additional system dependencies like ffmpeg.

Describe alternatives you've considered.

Manual testing like we are doing now. Not a great plan.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: maintenance enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant