Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper templating for emails #500

Closed
Nutomic opened this issue Feb 3, 2020 · 2 comments
Closed

Use proper templating for emails #500

Nutomic opened this issue Feb 3, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@Nutomic
Copy link
Member

Nutomic commented Feb 3, 2020

Right now the HTML for emails is just hardcoded, which is very ugly and also means that translations are not really possible. We should extract this into template files or something along those lines.

Example, you can find others by grepping for send_email.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Nutomic Nutomic added enhancement New feature or request translations labels Feb 3, 2020
@dessalines
Copy link
Member

Yup this is a big one I left for way later.

It should probably come after #440 , that way the db could read which languages a user can read, and send emails in a preferred language.

@Nutomic
Copy link
Member Author

Nutomic commented Dec 7, 2020

arewewebyet.org lists some l18n related crates. Looks to me like fluent would be best for our use case. Also this doesnt depend on #440 at all, we already have a language setting in the user profile which can be used for emails.

Edit: cargo-i18n might be better, because it supports common file formats.

Nutomic added a commit that referenced this issue Jan 20, 2022
Nutomic added a commit that referenced this issue Mar 2, 2022
Nutomic added a commit that referenced this issue Mar 2, 2022
Nutomic added a commit that referenced this issue Mar 2, 2022
Nutomic added a commit that referenced this issue Mar 2, 2022
Nutomic added a commit that referenced this issue Mar 14, 2022
Nutomic added a commit that referenced this issue Mar 21, 2022
Nutomic added a commit that referenced this issue Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants