Adding shortname fetching for users and communities. Fixes #1662 #1663

dessalines · 2021-07-19T03:37:25Z

No description provided.

crates/api_common/src/community.rs

crates/db_views/src/post_view.rs

crates/api_crud/src/community/read.rs

crates/apub/src/lib.rs

dessalines · 2021-07-19T14:22:38Z

crates/apub/src/lib.rs

+/// Takes in a shortname of the type dessalines@xyz.tld or dessalines (assumed to be local), and outputs the actor id.
+/// Used in the API for communities and users.
+pub fn build_actor_id_from_shortname(
+  endpoint_type: EndpointType,
+  short_name: &str,
+) -> Result<DbUrl, ParseError> {
+  let split = short_name.split('@').collect::<Vec<&str>>();
+
+  let name = split[0];
+
+  // If there's no @, its local
+  let domain = if split.len() == 1 {
+    Settings::get().get_protocol_and_hostname()
+  } else {
+    format!("https://{}", split[1])
+  };
+
+  generate_apub_endpoint_for_domain(endpoint_type, name, &domain)
+}


Builds the actor_id from the short name.

Actually here's a problem, you should use Settings::get().get_protocol_string() instead of hardcoding https.

Nutomic · 2021-07-20T04:31:19Z

Btw I noticed that you really have to read this diff from bottom to top, so that you start at the low-level database code, and read the api code later. I first tried reading it from the top and its impossible to understand. So maybe we should consider adding a prefix to our crate folder names to order them correctly.

Adding shortname fetching for users and communities. Fixes #1662

ad08474