-
-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming to slur_filter. Fixes #1773 #1801
Conversation
ab5a705
to
aa83019
Compare
@@ -42,7 +42,7 @@ pub struct Settings { | |||
pub pictrs_url: Option<String>, | |||
/// Regex for slurs which are prohibited. Example: `(\bThis\b)|(\bis\b)|(\bsample\b)` | |||
#[default(None)] | |||
pub additional_slurs: Option<String>, | |||
pub slur_filter: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can put #[doku(example = "some basic regex")]
to give an example. Maybe this would be a good place to put the old filter (instead of docker/lemmy.hjson).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my example was bad, i would put a valid regex here so that people see how it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean instead of putting Example: (\bThis\b)|(\bis\b)|(\bsample\b)
in a comment, remove that part and do #[doku(example = "(\bThis\b)|(\bis\b)|(\bsample\b)")]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still left the example in the comment, i dont think it makes sense to have it twice. Sorry to request so many changes :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K done.
No description provided.