Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login ilike bug. Fixes #1920 #1921

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Fix login ilike bug. Fixes #1920 #1921

merged 2 commits into from
Nov 22, 2021

Conversation

dessalines
Copy link
Member

No description provided.

@Nutomic
Copy link
Member

Nutomic commented Nov 19, 2021

There are a few more places where ilike is used, I think they could have similar problems. Eg fuzzy_search() should probably do an sql escape of the user provided string.

@dessalines
Copy link
Member Author

Fuzzy search must use ilike, otherwise the % characters wouldn't work.

@Nutomic
Copy link
Member

Nutomic commented Nov 19, 2021

Sure, but we should probably escape any user provided strings that get passed into ilike.

@Nutomic Nutomic merged commit 88e81dc into main Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants