Specify dependencies and metadata for entire workspace

[Nutomic]

We are now using Rust 1.64 in CI, so we can use this feature.

[dessalines]

Are you using any tool to analyze these, cargo deps maybe?

[dessalines]

Can't a lot of these dependencies use workspace = true also? Almost all of them are included in utils.

edit: okay I spose this seems good, since you're preferring to specify them higher up, then use them lower.

[Nutomic]

I excluded deps which are only used in one of our crates. Seems like it would be more annoying than helpful to specify them in two places in that case.

[Nutomic]

And only tools im using are cargo check/cargo tree.

[dessalines]

It might be more organized to make everything in all of these workspace crates use workspace = true, and move all the deps to the top level. Not sure.

[dessalines]

Guessing this is gonna fail CI check.

[dessalines]

Found something interesting, cargo deny, testing it out now:

cargo install --locked cargo-deny && cargo deny init && cargo deny check

[dessalines]

The exclamation point isn't necessary right?

[Nutomic]

Its necessary because we want to ensure that the command returns an error via exit code. This means the diesel dependency was not found, which is the goal in this case. Crates which pull in lemmy_api_common to access api structs (eg lemmybb) shouldnt have to compile diesel.

[Nutomic]

Some of the database tests are failing randomly, happened in other PRs as well:

failures:


---- impls::actor_language::tests::test_community_languages stdout ----

thread 'main' panicked at 'assertion failed: `(left == right)`

  left: `[LanguageId(37), LanguageId(47), LanguageId(135)]`,

 right: `[LanguageId(135), LanguageId(47), LanguageId(37)]`', crates/db_schema/src/impls/actor_language.rs:480:5

stack backtrace:

note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


---- impls::actor_language::tests::test_default_post_language stdout ----

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: DatabaseError(UniqueViolation, "duplicate key value violates unique constraint \"site_name_key\"")', crates/db_schema/src/impls/actor_language.rs:352:53

stack backtrace:

note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


---- impls::actor_language::tests::test_site_languages stdout ----

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: DatabaseError(UniqueViolation, "duplicate key value violates unique constraint \"site_name_key\"")', crates/db_schema/src/impls/actor_language.rs:352:53

stack backtrace:

note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


---- impls::actor_language::tests::test_user_languages stdout ----

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: DatabaseError(UniqueViolation, "duplicate key value violates unique constraint \"site_name_key\"")', crates/db_schema/src/impls/actor_language.rs:352:53

stack backtrace:

note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.



failures:

    impls::actor_language::tests::test_community_languages

    impls::actor_language::tests::test_default_post_language

    impls::actor_language::tests::test_site_languages

    impls::actor_language::tests::test_user_languages


test result: FAILED. 23 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 15.24s