Removing sniptt/monads for lemmy-js-client. #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
approved these changes
Jan 4, 2023
|
So I recently removed all the optionals and weird serializing necessary due to them from lemmy-js-client: LemmyNet/lemmy-js-client#99 And lemmy-ui: LemmyNet/lemmy-ui#886 I love the monads / rust-style options, but since they aren't the "native" way for nulls / optionals to work in typescript, they required a ton of annoying workarounds. There was also a typescript flag I was unaware of, The lemmy-ui rework touched every component and took a few days, but it was worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.