Only let top admin purge. Fixes #2731 #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
commented
Feb 13, 2023
| let admins = PersonViewSafe::admins(pool).await?; | ||
| let top_admin = admins | ||
| .get(0) | ||
| .ok_or_else(|| LemmyError::from_message("no admins"))?; |
There was a problem hiding this comment.
This is a nice way to convert a vector to an error if that index is missing. No idea why rust lets you get slices and them not be options / results, potentially throwing runtime errors.
Nutomic
approved these changes
Feb 14, 2023
Nutomic
force-pushed
the
top_admin_purge
branch
from
a3c0186
to
e0c0f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.