Remove actix_rt & use standard tokio spawn
#3158
Conversation
crates/api_common/src/site.rs
Outdated
| @@ -252,6 +253,8 @@ pub struct EditSite { | |||
| pub federation_debug: Option<bool>, | |||
| /// The number of federation workers. | |||
| pub federation_worker_count: Option<i32>, | |||
| /// The number of federation retry workers. | |||
| pub federation_retry_worker_count: Option<i32>, | |||
There was a problem hiding this comment.
I missed that your PR was adding this. In fact I want to get rid of the worker count setting, not add another one...
There was a problem hiding this comment.
I've raised a PR to have this as an option: LemmyNet/activitypub-federation-rust#45 if you set both these values to 0 then there isn't any limit.
|
@Nutomic for the diesel/schema changes, I did Same with the TOML, I think the formatter I use isn't quite right. I'll adjust both accordingly. (edit: I've adjusted both manually for now) |
|
Regarding the worker count settings, how about default to unlimited? Lemmy doesnt use a lot of memory, and if it does reach memory limits then most likely due to postgres and local api requests. @dessalines What do you think about this? I would also prefer to move worker counts to the config file, as its something for the hardware admin, not to be messed with by someone who is tasked to help with moderation. |
|
@Nutomic I've adjusted them to be unlimited (i.e, |
|
You need to run |
|
Thank you! |
* Remove `actix_rt` & use standard tokio spawn * Adjust rust log back down * Format correctly * Update cargo lock * Add DB settings * Change name and update to latest rev * Clean up formatting changes * Move `worker_count` and `worker_retry_count` to settings * Update defaults * Use `0.4.4` instead of git branch
Sister PR to LemmyNet/activitypub-federation-rust#42. Shows how lemmy can use the standard tokio work stealing queue.
At the moment it's a draft as it's dependent on the git branch rather than crates.io