Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DB local_user.theme type to text #3266

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

scme0
Copy link
Contributor

@scme0 scme0 commented Jun 22, 2023

Updates local_user.theme to type text to match local_site.default_theme

Fixes #3166

@@ -65,7 +65,7 @@ diesel::table! {
}

diesel::table! {
use diesel::sql_types::{Bool, Int4, Nullable, Text, Timestamp, Varchar};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this and similar changes in this file. They were auto generated... Should I revert them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diesel CLI is doing this for me too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which command are you running that this happens?

Copy link
Contributor

@kartikynwa kartikynwa Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nutomic diesel migration run. This change is in my community muting PR as well. It comes from running the migrations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep and also diesel migration redo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay fixed in #3293

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted those lines in this PR 👍

@scme0 scme0 marked this pull request as ready for review June 22, 2023 11:46
@Nutomic Nutomic merged commit c588640 into LemmyNet:main Jun 26, 2023
@scme0 scme0 deleted the scme/increase-user-theme-db-size branch June 26, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't have custom themes whose names are longer than 20 characters
3 participants