feat: allow all admins to purge content #3271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in issue: #2976
this removes the
is_top_admin
check from all purges, i've also deleted theis_top_admin
function itself since it's no longer usedas an aside in relation to the safety concerns, i believe a long term solution to this would be moving from a coarse-grained role-based system, to a fine-grained permissions + role system, where permissions can be defined for pretty much every server interaction and roles are just named bundles of permissions which can be assigned to users