-
-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re-added captcha checks #3289
Conversation
39f3ce6
to
9bc4ffc
Compare
Thanks. I will get to reviewing this hopefully early next week, sorry about the confusion. |
No worries, enjoy your weekend, hope you get some time to relax! |
8948663
to
9764366
Compare
24b4954
to
314e942
Compare
- removed redundant captcha expiry filter - added id and published fields to CaptchaAnswer
To make CI pass you need to replace
to this:
There are also some conflicts. |
- removed redundant captcha expiry filter - added id and published fields to CaptchaAnswer - modified diesel_ltree.patch to pass CI
- removed redundant captcha expiry filter - added id and published fields to CaptchaAnswer - modified diesel_ltree.patch to pass CI
thanks, modified the patch file and resolved conflicts, might be worth checking tho because dessalines was indicating here: #3289 (comment) that there shouldn't need to be changes to the patch file in this PR |
That comment is wrong. The patch file needs to be changed because the new table is inserted right next to one of the lines from the ltree diff, so the context changes and the existing patch fails to apply. |
creating a new PR as old one was reverted, see #3249 (comment)