Adjust the config check to be a separate faster to compile binary #3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cetra3
force-pushed
the
adjust_config_check
branch
from
3dec763
to
a90fed1
Compare
Nutomic
force-pushed
the
adjust_config_check
branch
from
a90fed1
to
b788bc5
Compare
Nutomic
approved these changes
Jun 26, 2023
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the print-config-check to a binary hosted by the
crates/utilscrate. Rather than build the entire lemmy server to check the config is updated, this will compile less & hopefully reduce thecheck_defaults_hjson_updatedstep in CI