Add Open links in new tab setting #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2023
Nutomic
approved these changes
Jun 26, 2023
Nutomic
force-pushed
the
lemmy-282/add-open-in-new-tab-setting
branch
from
4d5292b
to
b41b814
Compare
dessalines
reviewed
Jun 26, 2023
crates/db_schema/src/schema.rs
Outdated
| @@ -393,6 +393,7 @@ diesel::table! { | |||
| show_bot_accounts -> Bool, | |||
| show_read_posts -> Bool, | |||
| show_new_post_notifs -> Bool, | |||
| open_links_in_new_tab -> Bool, | |||
There was a problem hiding this comment.
This needs to be added at the end, the columns need to be in the correct order in this file (I think.)
There was a problem hiding this comment.
I've reordered the attribute
auto-merge was automatically disabled
June 27, 2023 18:32
Head branch was pushed to by a user without write access
Nutomic
reviewed
Jun 28, 2023
| pub email_verified: Option<bool>, | ||
| pub accepted_application: Option<bool>, | ||
| pub totp_2fa_secret: Option<Option<String>>, | ||
| pub totp_2fa_url: Option<Option<String>>, | ||
| pub open_links_in_new_tab: Option<bool>, |
There was a problem hiding this comment.
You declared the same field twice in a couple of places, so build is failing.
Nutomic
approved these changes
Jul 3, 2023
Nutomic
force-pushed
the
lemmy-282/add-open-in-new-tab-setting
branch
from
f50e709
to
fa193c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.