Fix missing sorting types #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
approved these changes
Jun 27, 2023
L3v3L
approved these changes
Jun 27, 2023
dessalines
reviewed
Jun 27, 2023
| @@ -4,7 +4,7 @@ update local_user set default_sort_type = 'TopDay' where default_sort_type in (' | |||
| -- rename the old enum | |||
| alter type sort_type_enum rename to sort_type_enum__; | |||
| -- create the new enum | |||
| CREATE TYPE sort_type_enum AS ENUM ('Active', 'Hot', 'New', 'Old', 'TopDay', 'TopWeek', 'TopMonth', 'TopYear', 'TopAll', 'MostComments', 'NewComments'); | |||
| CREATE TYPE sort_type_enum AS ENUM ('Active', 'Hot', 'New', 'Old', 'TopHour', 'TopSixHour', 'TopTwelveHour', 'TopDay', 'TopWeek', 'TopMonth', 'TopYear', 'TopAll', 'MostComments', 'NewComments'); | |||
There was a problem hiding this comment.
I don't think this is right. These must be in the correct order, you've just added them in the middle randomly.
There was a problem hiding this comment.
I'm sorry, I inserted them in the granularity order (i.e. hour < sixhours < twelvehours < day < etc.), will correct now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing sorting types in #3226 : #3226 (comment)