Adding rest of community sorts. Fixes #3374 #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
didn't know about this one |
Nutomic
reviewed
Jun 27, 2023
| @@ -183,12 +183,33 @@ impl<'a> CommunityQuery<'a> { | |||
| } | |||
|
|
|||
| match self.sort.unwrap_or(SortType::Hot) { | |||
| SortType::Hot => query = query.order_by(community_aggregates::hot_rank.desc()), | |||
| SortType::Active => query = query.order_by(community_aggregates::hot_rank.desc()), | |||
There was a problem hiding this comment.
It would be easier to read if you put use SortType::* before the match. Then you can do Hot | Active => ... in cases where the same statement is used for multiple cases.
Nutomic
approved these changes
Jun 29, 2023
Nutomic
force-pushed
the
add_missing_community_sorts
branch
from
c276426
to
bf8110c
Compare
Closed
|
Clippy is complaining that you should move the use. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.