Improved validation of display names (Fixes #3436) #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed validation of display names: reject names beginning with invisible unicode characters.
Josephos
changed the title
Formatting fix.
Nutomic
reviewed
Jul 3, 2023
crates/utils/src/utils/validation.rs
Outdated
| @@ -24,6 +24,9 @@ const BIO_MAX_LENGTH: usize = 300; | |||
| const SITE_NAME_MAX_LENGTH: usize = 20; | |||
| const SITE_NAME_MIN_LENGTH: usize = 1; | |||
| const SITE_DESCRIPTION_MAX_LENGTH: usize = 150; | |||
| const FORBIDDEN_DISPLAY_CHARS: [char; 7] = [ | |||
| '@', '\u{180e}', '\u{200b}', '\u{2060}', '\u{2800}', '\u{3164}', '\u{ffef}', | |||
There was a problem hiding this comment.
Do you have a reference for this list? The site below lists even more.
There was a problem hiding this comment.
I used this: https://unicode-explorer.com/articles/space-characters and manually tested most of them, added those that worked. Your list is better.
There was a problem hiding this comment.
Please include a comment with the link as well, and mention that these are specifically invisible chars.
Nutomic
reviewed
Jul 3, 2023
crates/utils/src/utils/validation.rs
Outdated
| @@ -42,8 +45,7 @@ pub fn is_valid_actor_name(name: &str, actor_name_max_length: usize) -> LemmyRes | |||
|
|
|||
| // Can't do a regex here, reverse lookarounds not supported | |||
| pub fn is_valid_display_name(name: &str, actor_name_max_length: usize) -> LemmyResult<()> { | |||
| let check = !name.starts_with('@') | |||
| && !name.starts_with('\u{200b}') | |||
| let check = !name.starts_with(FORBIDDEN_DISPLAY_CHARS) | |||
There was a problem hiding this comment.
How about disallowing these chars anywhere in the name?
There was a problem hiding this comment.
Implemented. Check for '@' is still done only for the first letter.
…for disallowed characters anywhere in the name.
|
Updated with expanded list of forbidden characters and check for occurrences anywhere in the name. |
dessalines
approved these changes
Jul 3, 2023
Nutomic
approved these changes
Jul 4, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed validation of display names: reject names beginning with invisible unicode characters.
Fixes #3436