Make hot rank not crash on future #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Jul 6, 2023
| hours_diff numeric := EXTRACT(EPOCH FROM (timezone('utc', now()) - published)) / 3600; | ||
| BEGIN | ||
| IF (hours_diff > 0) THEN | ||
| RETURN floor(10000 * log(greatest(1, score + 3)) / power((hours_diff + 2), 1.8))::integer; |
There was a problem hiding this comment.
Rather than the if statement, it'd probable be better to do greatest(0, hours_diff) + 2
There was a problem hiding this comment.
yeah i thought so too. i tried it, but the issue is that then those future posts stay at the top of hot as if they were posted 0 seconds ago (so they get an extremely high hot score if they get any upvotes at all). so instead i set to zero completely until they are not in the future anymore.
dessalines
approved these changes
Jul 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3494 by making hot_rank() return 0 if published is in the future