Dont send comment reply to user who has community blocked. Fixes #3684 #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The same check also needs to be added for blocked instance then. |
|
I thought blocked instance only cares about blocking the communities, not the users from those communities? EDIT: Sorry, yeah I spose that does make sense, my bad. |
|
Please add some test cases. Especially for |
…ly_to_blocked_community
Nutomic
reviewed
Nov 8, 2023
Nutomic
reviewed
Nov 8, 2023
Nutomic
reviewed
Nov 8, 2023
Nutomic
reviewed
Nov 8, 2023
| ); | ||
| if (!alphaComment) { | ||
| throw "Missing alpha comment before block"; | ||
| } |
There was a problem hiding this comment.
I prefer simple expect instead of such messages because its shorter and simpler, but no big deal
Nutomic
approved these changes
Nov 8, 2023
|
Tests are failing but that seems unrelated. |
Nutomic
pushed a commit
that referenced
this pull request
Nov 13, 2023
Nutomic
added a commit
that referenced
this pull request
Nov 13, 2023
Get rid of different inboxes, only use /inbox Remove shared_inbox_url db columns add code migration move to db migration, fixes machete fix sql drop inbox url unique constraints Dont create auth cookie in backend (#4136) dont change individual inboxes to shared inbox Dont send comment reply to user who has community blocked. Fixes #3684 (#4096) * Dont send comment reply to user who has community blocked. Fixes #3684 * Adding source instance block check. * Adding api test. * Addressing PR comments.
Nutomic
added a commit
that referenced
this pull request
Nov 13, 2023
Get rid of different inboxes, only use /inbox Remove shared_inbox_url db columns add code migration move to db migration, fixes machete fix sql drop inbox url unique constraints Dont create auth cookie in backend (#4136) dont change individual inboxes to shared inbox Dont send comment reply to user who has community blocked. Fixes #3684 (#4096) * Dont send comment reply to user who has community blocked. Fixes #3684 * Adding source instance block check. * Adding api test. * Addressing PR comments.
phiresky
pushed a commit
that referenced
this pull request
Nov 16, 2023
…es (#4138) * Merge /site_inbox into /inbox (fixes #4137) Get rid of different inboxes, only use /inbox Remove shared_inbox_url db columns add code migration move to db migration, fixes machete fix sql drop inbox url unique constraints Dont create auth cookie in backend (#4136) dont change individual inboxes to shared inbox Dont send comment reply to user who has community blocked. Fixes #3684 (#4096) * Dont send comment reply to user who has community blocked. Fixes #3684 * Adding source instance block check. * Adding api test. * Addressing PR comments. * move site inbox rewrite to db * fix test * clippy * clippy 2 * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.