-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homework for lesson 4 #61
Open
sulakin
wants to merge
14
commits into
Letto228:lecture-4
Choose a base branch
from
sulakin:lecture-4
base: lecture-4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project config settings
Lecture 2
Lecture 3
Letto228
requested changes
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Привет
Супер! Очень продуманный popup компонент получился.
Есть 2 нюанса которые смущают:
- Я бы рассмотрел кейс, когда в
popupTemplate
приходитundefined
, в теории такой кейс возможен, например, когда будет сбрасываться состояние переменной в которой хранится template. Если же в твоей архитектуре такого кейса нет, то тогда можно не учитывать кейс с undefined - В tempalte может быть прописан компонент, соответственно, при создании view на основе template - создастся и компонент используемый в нем. Вот в чем соль, при закрытии попапа, ожидаешь ли ты, что компонент будет уничтожен, что у него отработает хук OnDestroy, который выполнит отписки от подписок в компоненте(если они, конечно же там есть)?
Мне как раз таки кажется, что при закрытии попапа стоит уничтожать вставленный view, так будет более корректно, т.к. нет смысла держать рабочий компонент, раз попап с ним закрыли.
Возможно, у тебя попап используется для кейсов в которых обычное скрытие view, без его уничтожения, это подходящее решение
Буду ждать твоего ответа)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.