Merge pull request #48 from Li357/3.0.1-b7-ui-20-21-fixes

Fix Wednesday UI that mistaken starts on mod 2
Li357 · Jul 27, 2020 · 3b7ff07 · 3b7ff07
2 parents 1c1bb7d + 891ba73
commit 3b7ff07
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/app/src/components/schedule/ScheduleCard.tsx b/packages/app/src/components/schedule/ScheduleCard.tsx
@@ -118,8 +118,9 @@ const makeCardDayScheduleSelector = () => createSelector(
     const isFinals = scheduleType === 'FINALS';
 
     const revisedUserDaySchedule = injectAssemblyOrFinalsIfNeeded(schedule, scheduleType, day);
-    // Remove homeroom/no homeroom item on wednesday schedules
-    const userDaySchedule = revisedUserDaySchedule.slice(scheduleType === 'WEDNESDAY' ? 1 : 0);
+    // PATCH: scheduleType === 'WEDNESDAY' && day !== 3 condition is needed since the first item is already
+    // sliced off for normal Wednesday schedules (i.e. day === 3, see interpolateOpenMods)
+    const userDaySchedule = revisedUserDaySchedule.slice(scheduleType === 'WEDNESDAY' && day !== 3 ? 1 : 0);
 
     const cardDaySchedule = daySchedule.map(([start, end, modNumber]) => {
       const startTime = formatTime(start);

diff --git a/packages/app/src/utils/bugsnag.ts b/packages/app/src/utils/bugsnag.ts
@@ -29,7 +29,7 @@ function serializeState(state: AppState): IMetadata {
 }
 
 const config = new Configuration();
-config.codeBundleId = '3.0.1-b6';
+config.codeBundleId = '3.0.1-b7';
 config.notifyReleaseStages = ['production'];
 config.registerBeforeSendCallback((report) => {
   const state = store.getState();