Skip to content

Commit

Permalink
support best unbalaced pp scheduler (PaddlePaddle#9235)
Browse files Browse the repository at this point in the history
  • Loading branch information
LiYuRio committed Oct 12, 2024
1 parent 602b7d0 commit 2f446bb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions paddlenlp/trainer/training_args.py
Original file line number Diff line number Diff line change
Expand Up @@ -1120,6 +1120,7 @@ def split_parallel_config(parallel_config):
"enable_clear_every_step_cache",
"enable_overlap_p2p_comm",
"disable_batch_p2p_comm",
"best_unbalanced_scheduler",
]:
raise ValueError(
f"Found unknown pipeline mode config {x}, accpet config is disable_p2p_cache_shape, disable_partial_send_recv."
Expand Down Expand Up @@ -1158,6 +1159,7 @@ def split_parallel_config(parallel_config):
"overlap_p2p_comm": "enable_overlap_p2p_comm" in pipeline_parallel_config,
"clear_every_step_cache": "enable_clear_every_step_cache" in pipeline_parallel_config,
"use_batch_p2p_comm": "disable_batch_p2p_comm" not in pipeline_parallel_config,
"best_unbalanced_scheduler": "best_unbalanced_scheduler" in pipeline_parallel_config,
}
if dygraph_pp_configs["dp_comm_overlap"]:
raise ValueError("overlap has accuracy issue") # TODO: fix `overalap` + `delay_scale` issue
Expand Down

0 comments on commit 2f446bb

Please sign in to comment.