BrnBrokenLine: xDial support selected style #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violinday
changed the title
violinday
approved these changes
Sep 6, 2022
violinday
approved these changes
Sep 13, 2022
hexintao
reviewed
Sep 13, 2022
| if (isShowXDial) { | ||
| _drawXRuler(canvas, paint..color = xDialColor!); | ||
| } else { | ||
| // 此处逻辑已废弃 |
There was a problem hiding this comment.
那这样写？此处兼容之前 item.isShowXDial属性，建议使用全局isShowXDial
hexintao
reviewed
Sep 13, 2022
| (xDialValues![i].value - xDialMin!) / | ||
| (xDialMax! - xDialMin!) * | ||
| _fixedWidth; | ||
| bool isXRulerSelected = _selectedPointX == _xPosition; |
There was a problem hiding this comment.
两个 double 算出来的值的精度是一样的吗？用 == 会不会影响对比结果？
There was a problem hiding this comment.
这个问题提的非常好，给个大拇指
hexintao
approved these changes
Sep 22, 2022
violinday
added a commit
that referenced
this pull request
Sep 30, 2022
* 3.x: (21 commits) Update build_test.yml (#348) fix: BrnIconButton 传入字体无效问题 (#346) add attribute emptyImage (#344) 增加textInputAction (#337) fix BrnToast defaultoffset error (#343) fix docs (#342) feature: Add BrnSafeDialog (dismiss) instead of Navigator.pop to close the Dialog. (#321) BrnBrokenLine: xDial support selected style (#319) fix: BrnProgressChart 设置颜色，背景色，以及动画无效 (#326) feat: 增加focusNode prop，实现焦点可控 (#328) fix: BrnTextSelectFormItem 布局字偏上问题 (#331) [perf]: 优化代码：1、将 Container()，Container(width:0, height:0) 替换为 SizedBox.shrink()，2、将 InkWell 替换为 GestureDetector (#325) fix #333; (#335) Update brn_middle_input_diaolg.dart (#327) fix global style BrnCardTitleConfig don't work (#310) (#313) fix BrnMultiSelectTagsPicker style error (#316) (#320) Update build_test.yml (#323) optimize BrnPageLoading fix #295 (#298) Create i10n.md #fixbug: 修复issues275 (#301) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.