migrate brn_horizontal_steps、brn_step_line to null safety #39

leftcoding · 2021-12-27T02:33:40Z

migrate brn_step_line to null safety
optimization brn_horizontal_steps

* Theme: 优化单例实现，初步优化 BrnAllThemeConfig 属性获取不为 null * refactor:优化theme,暴露非null引用 * theme:去除无用信息及优化部分代码 * theme:增加属性类型

* 🎨 utils-EventBus添加null-safe * 🎨 修改theme配置功能及utils/brn_tools工具函数 null-safe * 🎨 EventBus添加null-safe(其他提交请忽略,输入回退) Co-authored-by: 大脸儿 <hexintao521@hotmail.com>

* refactor brn_toast * refactor brn_toast

zhoujuanjuan · 2021-12-30T07:11:00Z

lib/src/components/step/brn_horizontal_steps.dart

@@ -1,5 +1,4 @@
-// @dart=2.9
-
+import 'package:bruno/bruno.dart';


这个建议使用单个文件，会有循环引用问题

zhoujuanjuan · 2021-12-30T07:11:55Z

lib/src/components/step/brn_horizontal_steps.dart

+    return BrnThemeConfigurator.instance
+            .getConfig()
+            .commonConfig
+            ?.brandPrimary ??


这里的两处判空应该不需要了

zhoujuanjuan · 2021-12-30T07:16:06Z

lib/src/components/step/brn_step_line.dart

  }

  Widget _buildHighLightCircle() {
    return _buildColorCircleWidget(widget.highlightColor ??
-        BrnThemeConfigurator.instance.getConfig().commonConfig.brandPrimary);
+        BrnThemeConfigurator.instance.getConfig().commonConfig?.brandPrimary ??


好的，我改下

ShzMinato · 2021-12-31T03:20:53Z

lib/src/components/step/brn_horizontal_steps.dart

      if (index < currentIndex) {
-        // 当前index小于指定的活跃index
+        /// 当前index小于指定的活跃index


//就好啦

ShzMinato · 2021-12-31T03:22:53Z

lib/src/components/step/brn_step_line.dart

            BrnThemeConfigurator.instance
                .getConfig()
                .commonConfig
-                .brandPrimary);
+                ?.brandPrimary ??


这个地方是不是肯定不为null嘞

这个还没合并代码之前的，我改下后面再提交一下

ShzMinato

so cool～
@leftcoding

violinday · 2021-12-31T07:10:17Z

example/lib/sample/components/step/brn_horizontal_step_example.dart

  }
+}
+
+class SliderWidget extends StatefulWidget {


cool！
可否将 SliderWidget、BrnHorizontalStep 类放在 Bruno 库中~

好的，统一修改下

* Theme: 优化单例实现，初步优化 BrnAllThemeConfig 属性获取不为 null * refactor:优化theme,暴露非null引用 * theme:去除无用信息及优化部分代码 * theme:增加属性类型 * 优化修复 EventBus

* migrate brn_loading to null safety * mv loading content to brnString constants

into f/brn_step � Conflicts: � lib/src/components/step/brn_horizontal_steps.dart � lib/src/components/step/brn_step_line.dart

zhoujuanjuan · 2022-01-12T03:56:03Z

lib/src/theme/base/brn_default_config_utils.dart

@@ -119,29 +122,29 @@ class BrnDefaultConfigUtils {
    /// 文本字号
    ///
    /// 特殊数据展示，DIN Condensed数字字体，用于强吸引
-    fontSizeDIN: 28,
+    fontSizeDIN: 28.0,


这些已经优化，建议拉新代码

zhoujuanjuan

整体建议分步提，本次只提 step 相关内容可好

migrate brn_horizontal_steps、brn_step_line null safety

bea3ccc

leftcoding changed the title ~~migrate brn_horizontal_steps、brn_step_line null safety~~ migrate brn_horizontal_steps、brn_step_line to null safety Dec 27, 2021

kalifun and others added 4 commits December 27, 2021 15:00

🎨 BrnSearchText (LianjiaTech#36)

43acef4

🎨 utils-EventBus添加null-safe (LianjiaTech#23)

886c48e

* 🎨 utils-EventBus添加null-safe * 🎨 修改theme配置功能及utils/brn_tools工具函数 null-safe * 🎨 EventBus添加null-safe(其他提交请忽略,输入回退) Co-authored-by: 大脸儿 <hexintao521@hotmail.com>

refactor brn_toast (LianjiaTech#33)

081a7dc

* refactor brn_toast * refactor brn_toast

zhoujuanjuan reviewed Dec 30, 2021

View reviewed changes

ShzMinato reviewed Dec 31, 2021

View reviewed changes

violinday reviewed Dec 31, 2021

View reviewed changes

zhoujuanjuan and others added 6 commits December 31, 2021 22:49

优化 EventBus 单例实现 (LianjiaTech#43)

7dff62a

* Theme: 优化单例实现，初步优化 BrnAllThemeConfig 属性获取不为 null * refactor:优化theme,暴露非null引用 * theme:去除无用信息及优化部分代码 * theme:增加属性类型 * 优化修复 EventBus

brn_toast time change to seconds (LianjiaTech#45)

974e0da

migrate brn_loading to null safety (LianjiaTech#32)

3ef1aa2

* migrate brn_loading to null safety * mv loading content to brnString constants

migrate brn_horizontal_steps、brn_step_line null safety

95878df

optimization brn_horizontal_steps brn_step_line

fe29e81

Merge branch 'f/step_null_safety' of https://github.com/leftcoding/bruno

468f9d3

into f/brn_step � Conflicts: � lib/src/components/step/brn_horizontal_steps.dart � lib/src/components/step/brn_step_line.dart

zhoujuanjuan reviewed Jan 12, 2022

View reviewed changes

leftcoding closed this Jan 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

migrate brn_horizontal_steps、brn_step_line to null safety #39

migrate brn_horizontal_steps、brn_step_line to null safety #39

leftcoding commented Dec 27, 2021 •

edited

Loading

zhoujuanjuan Dec 30, 2021

zhoujuanjuan Dec 30, 2021

zhoujuanjuan Dec 30, 2021

leftcoding Dec 30, 2021

ShzMinato Dec 31, 2021

ShzMinato Dec 31, 2021

leftcoding Dec 31, 2021

ShzMinato left a comment

violinday Dec 31, 2021

leftcoding Dec 31, 2021

zhoujuanjuan Jan 12, 2022 •

edited

Loading

zhoujuanjuan left a comment

		@@ -1,5 +1,4 @@
		// @dart=2.9

		import 'package:bruno/bruno.dart';

migrate brn_horizontal_steps、brn_step_line to null safety #39

migrate brn_horizontal_steps、brn_step_line to null safety #39

Conversation

leftcoding commented Dec 27, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShzMinato left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhoujuanjuan Jan 12, 2022 • edited Loading

Choose a reason for hiding this comment

zhoujuanjuan left a comment

Choose a reason for hiding this comment

leftcoding commented Dec 27, 2021 •

edited

Loading

zhoujuanjuan Jan 12, 2022 •

edited

Loading