Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/libe env script shell #1392

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

shuds13
Copy link
Member

@shuds13 shuds13 commented Aug 1, 2024

Launch user environment scripts in shell.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.51%. Comparing base (ff96f93) to head (c899581).
Report is 29 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1392      +/-   ##
===========================================
+ Coverage    73.95%   76.51%   +2.56%     
===========================================
  Files           90       88       -2     
  Lines         8294     8019     -275     
  Branches      1476     1435      -41     
===========================================
+ Hits          6134     6136       +2     
+ Misses        1942     1665     -277     
  Partials       218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n01r
Copy link

n01r commented Aug 1, 2024

Sorry, I got another error but it looks like this one is on my side so I deleted my comment.

@shuds13 shuds13 requested review from jlnav and jmlarson1 August 2, 2024 18:34
Copy link
Member

@jmlarson1 jmlarson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a test of the shell=use_shell capability for launcher.launch?

@jlnav
Copy link
Member

jlnav commented Aug 5, 2024

This time around, I'm not sure there's that much to test since the added keyword is just passed through to subprocess. And the code specifying the parameter is naturally covered.

@shuds13 shuds13 merged commit fd555b8 into develop Aug 6, 2024
17 checks passed
@shuds13 shuds13 mentioned this pull request Aug 13, 2024
5 tasks
@jmlarson1 jmlarson1 deleted the feature/libe_env_script_shell branch August 15, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants