Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing content to advise use of README #155

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

jt14den
Copy link
Member

@jt14den jt14den commented Sep 7, 2024

fixes #36 by mirroring DataCarpentry ecology lesson recommended practice (using README to capture data prep) and not use note spreadsheet tab.
Still need to create screen shot on this one, so it is WIP.

fixes #36 by mirroring DataCarpentry ecology lesson recommended practice (using README to capture data prep) and not use note spreadsheet tab.
@jt14den jt14den self-assigned this Sep 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

Results of any additional workflows will appear here when they are done.

@jt14den
Copy link
Member Author

jt14den commented Sep 7, 2024

@morskyjezek Jesse, am still working on this one. Will add screen shot and make sure any references in later episodes are fixed. This might take a bit.

@morskyjezek
Copy link
Contributor

This is great! We've had these on the to do list for a while. Thank you for working on it! The PR check indicates some of the files were not creating the markdown correctly, do you have any insights on that? I'll also try to take a look.

@jt14den
Copy link
Member Author

jt14den commented Sep 26, 2024

@morskyjezek the workshop series finished last week, so i'm hoping to submit something this week. i wanted to get this PR draft started so I wouldn't forget.

@jt14den jt14den marked this pull request as ready for review September 27, 2024 13:57
@morskyjezek
Copy link
Contributor

This looks like a good change to me, but do you have any additional information on why the build workflow failed? @jt14den

@morskyjezek
Copy link
Contributor

morskyjezek commented Oct 29, 2024

It looks good when I run it locally.

@morskyjezek morskyjezek merged commit 43b254d into main Oct 29, 2024
2 of 3 checks passed
@morskyjezek morskyjezek deleted the switch-to-readme branch October 29, 2024 20:33
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : 43b254d
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2024-10-29 20:33:04 +0000
Message : Merge pull request #155 from LibraryCarpentry/switch-to-readme

changing content to advise use of README
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : fa10861
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-10-29 20:33:53 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 43b254d
Branch  : main
Author  : Jesse Johnston <morskyjezek@gmail.com>
Time    : 2024-10-29 20:33:04 +0000
Message : Merge pull request #155 from LibraryCarpentry/switch-to-readme

changing content to advise use of README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting recommendations about text documentation
2 participants