-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis integration #317
Travis integration #317
Conversation
Seems like the Travis integration is working, but the tests are broken |
.travis.yml
Outdated
python: | ||
- "3.6" | ||
- "3.6-dev" # 3.6 development branch | ||
- "3.7-dev" # 3.7 development branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would include 3.7 release as well as the dev branch. We may need to add something like allowed_failures
for the dev branches, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# command to run tests | ||
script: | ||
- mkdir logs | ||
- touch ./logs/concordia-celery.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the failures, we probably need to add ./manage.py collectstatic --noinput
here, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e452923 seems to have fixed that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with the mkdir and touch commands removed (after collectstatic was added) and I had to add them back in.
The tests are still erroring / failing, but I did get the 3.7 python release added. |
.travis.yml
Outdated
- python: "3.7-dev" | ||
- python: "3.7" | ||
dist: xenial | ||
sudo: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need the same config for 3.7-dev, otherwise 3-7-dev is just an old beta alpha of 3.7.0 and not a pre release of the next minor version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's quite a footnote: https://docs.travis-ci.com/user/languages/python/#development-releases-support
I'm guessing that means we can go back to a simple python:
block because we should use xenial everywhere.
I think this is ready now. @acdha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
https://travis-ci.org/LibraryOfCongress/concordia