Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis integration #317

Merged
merged 12 commits into from
Oct 2, 2018
Merged

Travis integration #317

merged 12 commits into from
Oct 2, 2018

Conversation

rstorey
Copy link
Member

@rstorey rstorey commented Oct 1, 2018

@rstorey
Copy link
Member Author

rstorey commented Oct 1, 2018

Seems like the Travis integration is working, but the tests are broken

@rstorey rstorey self-assigned this Oct 1, 2018
acdha
acdha previously approved these changes Oct 2, 2018
.travis.yml Outdated
python:
- "3.6"
- "3.6-dev" # 3.6 development branch
- "3.7-dev" # 3.7 development branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would include 3.7 release as well as the dev branch. We may need to add something like allowed_failures for the dev branches, too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# command to run tests
script:
- mkdir logs
- touch ./logs/concordia-celery.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the failures, we probably need to add ./manage.py collectstatic --noinput here, too

Copy link
Member

@acdha acdha Oct 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e452923 seems to have fixed that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the mkdir and touch commands removed (after collectstatic was added) and I had to add them back in.

@rstorey
Copy link
Member Author

rstorey commented Oct 2, 2018

The tests are still erroring / failing, but I did get the 3.7 python release added.

.travis.yml Outdated
- python: "3.7-dev"
- python: "3.7"
dist: xenial
sudo: true
Copy link

@michael-k michael-k Oct 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need the same config for 3.7-dev, otherwise 3-7-dev is just an old beta alpha of 3.7.0 and not a pre release of the next minor version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's quite a footnote: https://docs.travis-ci.com/user/languages/python/#development-releases-support

I'm guessing that means we can go back to a simple python: block because we should use xenial everywhere.

@rstorey
Copy link
Member Author

rstorey commented Oct 2, 2018

I think this is ready now. @acdha

Copy link
Member

@acdha acdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@acdha acdha merged commit 77925d7 into master Oct 2, 2018
@rstorey rstorey deleted the travis-integration branch October 4, 2018 22:01
chfw added a commit to moremoban/pypi-mobans that referenced this pull request Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants