fix: Undefined array key 2 #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was seeing the following errors in the log: PHP Warning: Undefined array key 2 in /var/www/html/Domain/ReservationItemView.php on line 490 The issue was caused by `array_splice()` After using `array_splice` then `$name_parts` is now only a single element array, as all other elements have been removed and used to generate `$firstnames`
JohnVillalovos
force-pushed
the
jlvillal/lastnames
branch
from
23d7f8a to
103cc3e
Compare
|
Shouldn't htis fix also applied to line 514 in Domain/ReservationItemView.php? |
|
Probably. I haven't hit that code path yet. Feel free to create a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was seeing the following errors in the log:
PHP Warning: Undefined array key 2 in /var/www/html/Domain/ReservationItemView.php on line 490
The issue was caused by
array_splice()After using
array_splicethen$name_partsis now only a single element array, as all other elements have been removed and used to generate$firstnames