-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restoring trainer after lr_find()
#14113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callidior
requested review from
SkafteNicki,
Borda,
awaelchli,
williamFalcon,
tchaton,
carmocca,
justusschock,
kaushikb11 and
rohitgr7
as code owners
August 9, 2022 10:58
carmocca
added
bug
Something isn't working
tuner
community
This PR is from the community
labels
Aug 20, 2022
carmocca
approved these changes
Aug 20, 2022
carmocca
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
rohitgr7
approved these changes
Aug 22, 2022
awaelchli
approved these changes
Aug 23, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Aug 26, 2022
rohitgr7
pushed a commit
that referenced
this pull request
Aug 27, 2022
lexierule
pushed a commit
that referenced
this pull request
Aug 31, 2022
FYI, this PR created an issue with convergence and I am investigating now what the cause is. Repro here: #14824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #12670: After using the LR finder and then training the model with the same trainer instance (which is the standard use-case), an incorrect learning rate schedule is used, leading to immediate divergence.
This bug was introduced in Lightning version 1.6 by commit a6a28e0, which removed two lines responsible for resetting the
init_optimizers
method of the trainer after it has been replaced with a wrapper changing the LR scheduler to one trying different learning rates.This PR reintroduces these two lines and updates them to match the current codebase, where
trainer.init_optimizers
has been renamed totrainer.strategy.setup_optimizers
.Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃