Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicon to match Lightning AI app consistency #20290

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

EmilieLny
Copy link
Contributor

@EmilieLny EmilieLny commented Sep 19, 2024

What does this PR do?

This PR updates the favicon of the repository to match the one used in the Lightning AI app, ensuring consistency across our branding. The favicon includes several sizes (16x16px, 48x48px, 224x224px) for optimal display.

BEFORE:
image

AFTER:
image

Lightning ai's home page:
image

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20290.org.readthedocs.build/en/20290/

@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Sep 19, 2024
@Borda Borda merged commit 48279a7 into Lightning-AI:master Sep 20, 2024
18 of 19 checks passed
@mergify mergify bot added the ready PRs ready to be merged label Sep 20, 2024
@neilbhatt
Copy link

@EmilieLny : what does this look like when you have a studio running w/ the green 'active' dot?

@EmilieLny
Copy link
Contributor Author

@EmilieLny : what does this look like when you have a studio running w/ the green 'active' dot?

I didn't change the one in the studio: so it looks the same as the one you can see today in production

Borda pushed a commit that referenced this pull request Sep 26, 2024
* Update favicon

* Update favicons - all sizes

(cherry picked from commit 48279a7)
lexierule pushed a commit that referenced this pull request Sep 27, 2024
* Update favicon

* Update favicons - all sizes

(cherry picked from commit 48279a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants