Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix failing make #5988

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Docs: fix failing make #5988

merged 3 commits into from
Feb 15, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 15, 2021

What does this PR do?

a hotfix on failing to make docs... sphinx-doc/sphinx#8880

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added docs Documentation related priority: 0 High priority task labels Feb 15, 2021
@Borda Borda added this to the 1.2 milestone Feb 15, 2021
@Borda Borda enabled auto-merge (squash) February 15, 2021 19:30
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #5988 (25b7fad) into master (d422ef2) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5988   +/-   ##
======================================
- Coverage      90%     90%   -0%     
======================================
  Files         170     170           
  Lines       11789   11789           
======================================
- Hits        10669   10640   -29     
- Misses       1120    1149   +29     

@Borda Borda added the ready PRs ready to be merged label Feb 15, 2021
@Borda Borda merged commit ae4dca9 into master Feb 15, 2021
@Borda Borda deleted the docs/fix-build branch February 15, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants