Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Patch Release v1.3.8 [full merge, no squash] #8198

Merged
merged 9 commits into from
Jul 1, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 29, 2021

What does this PR do?

Weekly patch release 1.3.8

Commits since last week:

gh pr list -s merged -S 'merged:2021-06-22T12:00:00.000Z..2021-06-30T23:30:00.000Z' --json mergedAt,milestone,url,mergeCommit,title --jq 'sort_by(.mergedAt) | reverse | .[] | select((.milestone.title == "v1.3.x") or (.milestone.title == null)) | [.url, .mergeCommit.oid, .title] | join(" ")' --limit 100
https://github.com/PyTorchLightning/pytorch-lightning/pull/8172 d6435a5b730334a83370c35fd1db70a11b83e85a Bugfix/swa iterable dset
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8181 b1d8840fd86221d06751e49f3cf97efc2c8238c4 Fix metric attribute lookup
ok https://github.com/PyTorchLightning/pytorch-lightning/pull/8165 bf54ac1cad1bcb6fa86dd23591a57b32ef7ed234 fix NCCL error with non-consecutive trainer gpus
ok https://github.com/PyTorchLightning/pytorch-lightning/pull/8167 c521624a928b2665965830590b2f37b347a86c43 [bugfix] Add mechanism to prevent deadlock for DDP on Exception Trigger
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8171 1f025789fcb35180b6e631dbb8e96066d8eb41b4 [bugfix] Clean Validation Sanity Checking metrics
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8174 c4492ad6aa63b764c95912c9f6bcf8784a967b08 [bugfix] Resolve memory not logged when missing metrics
ok https://github.com/PyTorchLightning/pytorch-lightning/pull/8170 2a372e368282acb4387f0cdb40bce181c535ede4 Fix module dict in base finetuning
ok https://github.com/PyTorchLightning/pytorch-lightning/pull/8163 b978d2a1f2f9cc9942971a6e252ccd1209a9269b remove metric deprecation message at module import level
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8156 03154eb30a0af07c7fb7d0d47726b19ecdc53d11 Refactor unnecessary `else` / `elif` when `if` block has a `return` statement
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8164 67f7e1318f1f6ed6325c41814bfa304ce73bd881 Fix dangerous default argument
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8147 9bd3747c71c1fb44d7da3947618711388d7f2c8f Remove unnecessary use of comprehension
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8155 c3065c5ce93ea4baa9062d7eb08f63961b261fac Iterate dictionary directly
ok https://github.com/PyTorchLightning/pytorch-lightning/pull/8111 51ea84222ba07b45d01d94348f8e671e50fccc7e resurface lost ddp info message
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8151 28afc7a10d9f9c1160935fb5c81a1a8c0492b392 ignore tests in DeepSource analyses
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8149 e11fe19673b3e7035f9625345924d90d9dc1d39e Remove unnecessary use of comprehension
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8144 3526d9323ae7e180adeb7a97709daa37af95293b add .deepsource.toml
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8134 a299659c732fb46d00446f976b9d10ddee6f6cb5 remove GridConfig instantiation in lightning (so the user needs to pass one)
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8122 ad957108128776463470830b3a5f4ad89be23002 Document exceptions in Utilities
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8096 0ba147d98aecb900074b82ce1e81efa715321c8d Hotfix Patch Release v1.3.7post0 [full merge, no squash]
ok https://github.com/PyTorchLightning/pytorch-lightning/pull/8095 8bd7b1bdd7d3f723822e78908033cf0a6743713a Add torchelastic check when sanitizing GPUs
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8079 58b47dabce89c82fcc81bf93932b3c1f938dac72 Add `log_device_info` to Trainer
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8085 6dd7797c97984c0e05e98b3cb7fed633cc409dce Deprecate moved warning functions
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8078 8bce39431ec6cdbe7c3db336082f7c4036170f44 Use XLA utility API to move data to CPU (Single TPU core)
xx https://github.com/PyTorchLightning/pytorch-lightning/pull/8074 1a6709da93e650f155097087d4030a6ebd264143 Weekly Patch Release v1.3.7 [full merge, no squash]
ok https://github.com/PyTorchLightning/pytorch-lightning/pull/8030 8cc646f05b9a9b6bb2b4826d402eb837e240c426 Specify packaging version to be more than 17.0

Chosen commits:

https://github.com/PyTorchLightning/pytorch-lightning/pull/8172 d6435a5b730334a83370c35fd1db70a11b83e85a Bugfix/swa iterable dset
https://github.com/PyTorchLightning/pytorch-lightning/pull/8165 bf54ac1cad1bcb6fa86dd23591a57b32ef7ed234 fix NCCL error with non-consecutive trainer gpus
https://github.com/PyTorchLightning/pytorch-lightning/pull/8167 c521624a928b2665965830590b2f37b347a86c43 [bugfix] Add mechanism to prevent deadlock for DDP on Exception Trigger
https://github.com/PyTorchLightning/pytorch-lightning/pull/8170 2a372e368282acb4387f0cdb40bce181c535ede4 Fix module dict in base finetuning
https://github.com/PyTorchLightning/pytorch-lightning/pull/8163 b978d2a1f2f9cc9942971a6e252ccd1209a9269b remove metric deprecation message at module import level
https://github.com/PyTorchLightning/pytorch-lightning/pull/8111 51ea84222ba07b45d01d94348f8e671e50fccc7e resurface lost ddp info message
https://github.com/PyTorchLightning/pytorch-lightning/pull/8095 8bd7b1bdd7d3f723822e78908033cf0a6743713a Add torchelastic check when sanitizing GPUs
https://github.com/PyTorchLightning/pytorch-lightning/pull/8030 8cc646f05b9a9b6bb2b4826d402eb837e240c426 Specify packaging version to be more than 17.0

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #8198 (a19fbd4) into release/1.3.x (afc69e4) will decrease coverage by 5%.
The diff coverage is 71%.

@@              Coverage Diff               @@
##           release/1.3.x   #8198    +/-   ##
==============================================
- Coverage             92%     87%    -5%     
==============================================
  Files                200     200            
  Lines              13096   13131    +35     
==============================================
- Hits               12023   11464   -559     
- Misses              1073    1667   +594     

@pep8speaks
Copy link

pep8speaks commented Jun 30, 2021

Hello @awaelchli! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-01 12:44:03 UTC

@awaelchli awaelchli force-pushed the 1.3.8-draft branch 2 times, most recently from 2d98abb to 2042633 Compare June 30, 2021 18:14
@awaelchli awaelchli marked this pull request as ready for review June 30, 2021 18:55
CHANGELOG.md Show resolved Hide resolved
GabrielePicco and others added 8 commits July 1, 2021 13:42
* Add torchelastic check

* Add changelog

* Address review

* fix
* Fix module dict in base finetuning

* Update CHANGELOG.md
…er (#8167)

* add mechanism to prevent deadlock

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* resolve flake8 + update changelog

* update on comments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

* remove space

* resolve bugs

* overwrite config

* update on comments

* update on comments

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update

* update

* update test with comments

* Update pytorch_lightning/plugins/training_type/parallel.py

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>

* update on comments

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
* device ids in barrier

x

x

s

same fix for spawn

fix non-nccl

x

* add changelog

* get nccl backend

* get backend

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
* add test

* add fix

* Update CHANGELOG.md
@awaelchli awaelchli added the priority: 0 High priority task label Jul 1, 2021
@lexierule lexierule merged commit 7b3bf48 into release/1.3.x Jul 1, 2021
@lexierule lexierule deleted the 1.3.8-draft branch July 1, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants