-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: update InfoLM
class to dynamically set higher_is_better
#2674
improve: update InfoLM
class to dynamically set higher_is_better
#2674
Conversation
…ed on information_measure
InfoLM
class to dynamically set higher_is_better
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2674 +/- ##
========================================
- Coverage 69% 39% -30%
========================================
Files 316 316
Lines 17897 17900 +3
========================================
- Hits 12325 7027 -5298
- Misses 5572 10873 +5301 |
Im still not sure where to put the info that was requested for the higher is better but incorporated the changes asked for the |
@Borda can you give more specific instructions on what you want changed here? |
@Borda should be good to go now |
…ed on information_measure
What does this PR do?
Fixes #2659
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
I had problems with the devcontainer and the environment.
Might try and add tests for this but it seems the devcontainer uses the torchmetrics in
/usr/local/lib/python3.9/site-packages
(or similar depending on python) and its not obvious to me how you are supposed to setup things to easily/quickly add tests? I ended up just doing editable install.I manually checked all the values but if I add a test ill try and include some info/example for each of these that shows the metric output on strs.
📚 Documentation preview 📚: https://torchmetrics--2674.org.readthedocs.build/en/2674/