CI: fix ifs conditions #1310
Merged
CI: fix ifs conditions #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
SkafteNicki
approved these changes
Nov 3, 2022
|
Not sure why it is pending for so long... :/ |
justusschock
approved these changes
Nov 3, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1310 +/- ##
======================================
Coverage 87% 87%
======================================
Files 190 190
Lines 11120 11120
======================================
Hits 9620 9620
Misses 1500 1500 |
stancld
approved these changes
Nov 3, 2022
Borda
added a commit
that referenced
this pull request
Nov 16, 2022
(cherry picked from commit 0c66f03)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As #1308 was skipping the oldest replacement step, even for the oldest, the min integration dependency was never tested... 🐰
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃