-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLIP score #1314
Add CLIP score #1314
Conversation
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1314 +/- ##
======================================
- Coverage 87% 87% -0%
======================================
Files 204 208 +4
Lines 11621 11695 +74
======================================
+ Hits 10100 10134 +34
- Misses 1521 1561 +40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool to have the first multimodal metric in torchmetrics
. Just a few nitpicks, otherwise great work! 👍
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb work! 💪
@SkafteNicki sorry, it was my bad to ask for var with min Trnformer version while they are now used only in one domain so there is no case of misconfiguration... |
What does this PR do?
Fixes #1311
Adds CLIP score which will be our first multi modal metric :D
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃