Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLIP score #1314

Merged
merged 44 commits into from
Nov 18, 2022
Merged

Add CLIP score #1314

merged 44 commits into from
Nov 18, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 5, 2022

What does this PR do?

Fixes #1311
Adds CLIP score which will be our first multi modal metric :D

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added this to the v0.11 milestone Nov 5, 2022
@SkafteNicki SkafteNicki mentioned this pull request Nov 5, 2022
@SkafteNicki SkafteNicki marked this pull request as ready for review November 10, 2022 14:55
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1314 (56dc6f7) into master (e4014f4) will decrease coverage by 0%.
The diff coverage is 46%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1314   +/-   ##
======================================
- Coverage      87%     87%   -0%     
======================================
  Files         204     208    +4     
  Lines       11621   11695   +74     
======================================
+ Hits        10100   10134   +34     
- Misses       1521    1561   +40     

Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to have the first multimodal metric in torchmetrics. Just a few nitpicks, otherwise great work! 👍

docs/source/index.rst Show resolved Hide resolved
docs/source/multimodal/clip_score.rst Show resolved Hide resolved
src/torchmetrics/multimodal/clip_score.py Outdated Show resolved Hide resolved
src/torchmetrics/multimodal/clip_score.py Outdated Show resolved Hide resolved
src/torchmetrics/multimodal/clip_score.py Outdated Show resolved Hide resolved
src/torchmetrics/multimodal/clip_score.py Outdated Show resolved Hide resolved
src/torchmetrics/multimodal/clip_score.py Outdated Show resolved Hide resolved
tests/unittests/multimodal/test_clip_score.py Outdated Show resolved Hide resolved
tests/unittests/multimodal/test_clip_score.py Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Nov 17, 2022
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb work! 💪

docs/source/index.rst Outdated Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) November 17, 2022 10:00
@mergify mergify bot added the ready label Nov 17, 2022
requirements/text_test.txt Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Nov 17, 2022

@SkafteNicki sorry, it was my bad to ask for var with min Trnformer version while they are now used only in one domain so there is no case of misconfiguration...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLIP score
3 participants