Prevent iteration over metrics #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
justusschock,
Borda,
tchaton and
ethanwharris
as code owners
justusschock
approved these changes
Nov 8, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
======================================
Coverage 87% 87%
======================================
Files 195 195
Lines 11346 11348 +2
======================================
+ Hits 9838 9840 +2
Misses 1508 1508 |
stancld
approved these changes
Nov 8, 2022
Borda
approved these changes
Nov 8, 2022
Borda
pushed a commit
that referenced
this pull request
Nov 16, 2022
* fix * changelog Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 00bb1ed)
Borda
pushed a commit
that referenced
this pull request
Nov 16, 2022
* fix * changelog Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 00bb1ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1319
Prevents users from accidentally end up in a infinite loop if they try to iterate over a single metric.
The reason currently is that we implement the
__getitem__method to create compositional metrics for indexing and we therefore need to explicit prevent iteration.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃