Add Tschuprow's T and Pearson's Contingency Coefficient #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancld
requested review from
edenlightning,
SkafteNicki,
Borda,
justusschock,
tchaton and
ethanwharris
as code owners
SkafteNicki
reviewed
Nov 14, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
========================================
- Coverage 87% 33% -54%
========================================
Files 200 204 +4
Lines 11474 11621 +147
========================================
- Hits 9951 3851 -6100
- Misses 1523 7770 +6247 |
SkafteNicki
approved these changes
Nov 15, 2022
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
for more information, see https://pre-commit.ci
|
@Borda please re-review :] |
Borda
approved these changes
Nov 15, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1299
fixes #1335
This MR adds Tschuprow's T, and (very similar) Pearson's Contingency Coefficient
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃