-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return also classes for MAP metric #1419
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1419 +/- ##
========================================
- Coverage 90% 36% -54%
========================================
Files 211 211
Lines 10849 10850 +1
========================================
- Hits 9719 3870 -5849
- Misses 1130 6980 +5850 |
Unfortunately this makes it much more difficult to use this metric in Lightning. The following code: class Foo(LightningModule):
def __init__(self):
self.metric = MeanAveragePrecision()
def on_validation_epoch_end(self):
self.log_dict(self.metric.compute()) used to work in 0.11.4. However, this PR adds a new
Here, |
What does this PR do?
Fixes #1417
Returns also
classes
for MAP metric.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃