-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding psnrb #1421
Adding psnrb #1421
Conversation
@Borda @SkafteNicki Any help regarding the failing tests would be really helpful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, already looking good.
Please also add entry in changelog :)
@SkafteNicki I have almost made all the changes as you suggested ,but I require some help as to what might have caused this error while running pytest |
for more information, see https://pre-commit.ci
@Borda @SkafteNicki I cannot understand why its still giving the import error,even after the init file has been fixed. |
seems you used the previous PSNR but did not update the class name, also curious if we could rather reuse some functionality instead of writing all from the ground... 🐰 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
========================================
- Coverage 88% 42% -45%
========================================
Files 238 240 +2
Lines 13360 13510 +150
========================================
- Hits 11741 5738 -6003
- Misses 1619 7772 +6153 |
What does this PR do?
Part of #799
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃