Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/50 panoptic quality #1435

Closed
wants to merge 42 commits into from
Closed

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Jan 9, 2023

New PR based on original PR from @niberger #929

What does this PR do?

Add the panoptic quality metric, as defined in the reference paper.
This implementation differ from the reference implementation of the COCO dataset on the following points:

  • The categories have to be declared at metric initialization.
  • Any undefined category will be considered as an unlabelled (void) region.
  • The input format for panoptic images are Tensor of shape (height, width, 2), where the first number of each pixel is the category id and the second number is the instance id.
  • No support for group of instances (crowds in COCO).

Fixes #50

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@justusschock justusschock marked this pull request as ready for review January 9, 2023 12:02
@justusschock
Copy link
Member Author

NOTE before squash merging, make sure that @niberger is mentioned as co-author

@justusschock justusschock enabled auto-merge (squash) January 9, 2023 12:03
@justusschock justusschock marked this pull request as draft January 9, 2023 14:54
auto-merge was automatically disabled January 9, 2023 14:54

Pull request was converted to draft

@Borda
Copy link
Member

Borda commented Feb 7, 2023

@justusschock can we rather finish #929 seems still open still up to date...

@Borda Borda mentioned this pull request Feb 14, 2023
4 tasks
@Borda Borda closed this in #929 Feb 14, 2023
@justusschock
Copy link
Member Author

@Borda yes, this was an intermediate work because I couldn't push to the other branch

@Borda Borda deleted the feature/50_panoptic_quality branch February 22, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics] Panoptic Quality
3 participants