Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClassificationTask Enum #1479

Merged
merged 32 commits into from
Feb 7, 2023
Merged

Add ClassificationTask Enum #1479

merged 32 commits into from
Feb 7, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Feb 3, 2023

What does this PR do?

Fixes #1478

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

SkafteNicki and others added 3 commits February 3, 2023 14:22
…113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>

* gh: update templates

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@SkafteNicki SkafteNicki added the enhancement New feature or request label Feb 3, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Feb 3, 2023
@Borda Borda force-pushed the classification/enum branch from 20b94d5 to 9bd0063 Compare February 3, 2023 13:33
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, but already LGTM!

Thanks for implementing <3

src/torchmetrics/utilities/enums.py Outdated Show resolved Hide resolved
@stancld
Copy link
Contributor

stancld commented Feb 4, 2023

We also need to import EnumStr instead of StrEnum as we're using an older version of lightning utilities.

@Borda
Copy link
Member

Borda commented Feb 5, 2023

We also need to import EnumStr instead of StrEnum as we're using an older version of lightning utilities.

Just set the min version to 0.5.0

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1479 (2067b00) into master (82f2e45) will decrease coverage by 36%.
The diff coverage is 28%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1479     +/-   ##
========================================
- Coverage      88%     52%    -36%     
========================================
  Files         213     213             
  Lines       10925   10987     +62     
========================================
- Hits         9614    5676   -3938     
- Misses       1311    5311   +4000     

@mergify mergify bot added the has conflicts label Feb 6, 2023
@mergify mergify bot removed the has conflicts label Feb 6, 2023
@Borda Borda enabled auto-merge (squash) February 6, 2023 16:05
@mergify mergify bot added ready and removed ready labels Feb 7, 2023
@mergify mergify bot added the ready label Feb 7, 2023
@Borda Borda merged commit b95d482 into master Feb 7, 2023
@Borda Borda deleted the classification/enum branch February 7, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Enum for task in classification metrics
3 participants