-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent metric dtype
conversion when metric is part of LightningModule
#1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates and defaults
Prevent dtype conversion of metric states in LightningModule
Formatting fix with pre-commit
FarzanT
requested review from
SkafteNicki,
justusschock,
Borda and
tchaton
as code owners
March 3, 2023 18:10
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1583 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 225 225
Lines 11926 11938 +12
======================================
+ Hits 10547 10555 +8
- Misses 1379 1383 +4 |
SkafteNicki
approved these changes
Mar 6, 2023
justusschock
approved these changes
Mar 6, 2023
Borda
changed the title
Prevent metric state dtype conversion when metric is part of LightningModule
Prevent metric Mar 6, 2023
dtype
conversion when metric is part of LightningModule
seems that the GPU tests are hanging... 🤔 |
SkafteNicki
reviewed
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1561
Added a simple check to prevent applying
.half()
and.float()
calls that are passed on the LightningModule to metric states and defaults. Instead, users will have to useset_dtype()
, as proposed in #493.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃