Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting 10/n #1610

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Add plotting 10/n #1610

merged 4 commits into from
Mar 13, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes part of #1406
Add plotting to a few more metrics (some retrieval metrics)

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 13, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 13, 2023
@mergify mergify bot requested a review from a team March 13, 2023 08:46
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1610 (33dcb9e) into master (3f74920) will decrease coverage by 0%.
The diff coverage is 86%.

❗ Current head 33dcb9e differs from pull request most recent head 925522f. Consider uploading reports for the commit 925522f to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1610   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         226     226           
  Lines       12039   12065   +26     
======================================
+ Hits        10645   10667   +22     
- Misses       1394    1398    +4     

@mergify mergify bot added the ready label Mar 13, 2023
@Borda Borda enabled auto-merge (squash) March 13, 2023 12:28
@Borda Borda disabled auto-merge March 13, 2023 22:37
@Borda Borda merged commit 7a2e88a into master Mar 13, 2023
@Borda Borda deleted the plot/retrieval branch March 13, 2023 22:37
@mergify mergify bot removed the ready label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants